Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support in-memory storage of MetricProfile #1235

Merged
merged 16 commits into from
Jul 25, 2024
Merged

Support in-memory storage of MetricProfile #1235

merged 16 commits into from
Jul 25, 2024

Conversation

shreyabiradar07
Copy link
Contributor

@shreyabiradar07 shreyabiradar07 commented Jul 15, 2024 •
edited
Loading

Description

This PR implements in-memory storage of MetricProfile during Autotune initialization and after creating a new metric profile

NOTE: this PR is created on top of #1224 and hence should be merged first

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: minikube

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

docker image - quay.io/shbirada/metric_profile:hackathon

@shreyabiradar07 shreyabiradar07 self-assigned this Jul 15, 2024
@shreyabiradar07 shreyabiradar07 added the kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase label Jul 15, 2024
msvinaykumar
msvinaykumar approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@msvinaykumar msvinaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per
#1224

LGTM

@msvinaykumar msvinaykumar mentioned this pull request Jul 25, 2024
Merged
12 tasks
@chandrams chandrams merged commit eda9d03 into kruize:202407-hackathon Jul 25, 2024
2 of 3 checks passed
@rbadagandi1 rbadagandi1 added this to the Kruize 0.0.24_rm Release milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvinaykumar msvinaykumar msvinaykumar approved these changes

@dinogun dinogun Awaiting requested review from dinogun

Assignees

@shreyabiradar07 shreyabiradar07

Labels
kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase remote_monitoring
Projects
Monitoring
Status: Done
Milestone
Hackathon branch
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyabiradar07 @msvinaykumar @chandrams @rbadagandi1