-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support in-memory storage of MetricProfile #1235
Merged
chandrams
merged 16 commits into
kruize:202407-hackathon
from
shreyabiradar07:metric-profile-in-memory
Jul 25, 2024
Merged
Support in-memory storage of MetricProfile #1235
chandrams
merged 16 commits into
kruize:202407-hackathon
from
shreyabiradar07:metric-profile-in-memory
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a2a30e.
shreyabiradar07
added
the
kruize-local
Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase
label
Jul 15, 2024
msvinaykumar
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per
#1224
LGTM
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kruize-local
Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase
remote_monitoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements in-memory storage of
MetricProfile
during Autotune initialization and after creating a new metric profileNOTE: this PR is created on top of #1224 and hence should be merged first
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
docker image -
quay.io/shbirada/metric_profile:hackathon